Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.7.1 backports 1 #38413

Merged
merged 15 commits into from
Jan 27, 2024
Merged

3.7.1 backports 1 #38413

merged 15 commits into from
Jan 27, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jan 26, 2024

Please don't merge, I will merge it myself.

gastaldi and others added 14 commits January 26, 2024 13:34
@gastaldi @gsmet
Register JDBC RowSet required bundle
712eb12 
(cherry picked from commit 9661266)
@geoand @gsmet
Ensure that response body of unsuccessful SSE request can be read
f05b54f 
Fixes: quarkusio#38325
(cherry picked from commit e2668c5)
@DavideD @gsmet
Bump Hibernate Reactive from 2.2.1.Final to 2.2.2.Final
0da3684 
(cherry picked from commit c6f8a67)
@gastaldi @gsmet
Include RowSet properties file in native image
b192701 
This fixes the `Resource javax/sql/rowset/rowset.properties not found` error

(cherry picked from commit 131a122)
@aloubyansky @gsmet
Make sure extension metadata properties are not including timestamps
59758c5 
(cherry picked from commit e14daa1)
@sberyozkin @gsmet
Make it easier to get the default OIDC metadata
e38d464 
(cherry picked from commit 658321d)
@gsmet
Use UpdateDependencyVersionOperation first to update Quarkus version
f0c20be 
It is important to try that first as that recipe updates the OpenRewrite
model, and thus the BOM, for the following recipes.
This is important for the recipe syncing the Hibernate ORM modelgen
annotation processor with the version coming from the BOM as we want to
sync it with the updated version.

(cherry picked from commit f2fda62)
@gsmet
Update Gradle Maven extensions
edeef99 
(cherry picked from commit 11856be)
@aloubyansky @gsmet
Don't assume module that has child modules is the parent of those mod…
3c0e278 
…ules

(cherry picked from commit 09c312d)
@geoand @gsmet
Use simpler collection creation idioms in code example
2f506ec 
(cherry picked from commit 4f4593e)
@dependabot @gsmet
Bump io.smallrye.reactive:mutiny from 2.5.1 to 2.5.5
cb9e069 
Bumps [io.smallrye.reactive:mutiny](https://github.com/smallrye/smallrye-mutiny) from 2.5.1 to 2.5.5.
- [Release notes](https://github.com/smallrye/smallrye-mutiny/releases)
- [Commits](smallrye/smallrye-mutiny@2.5.1...2.5.5)

---
updated-dependencies:
- dependency-name: io.smallrye.reactive:mutiny
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit fde099e)
@geoand @gsmet
Make sure that @WithFormRead doesn't break body handling
cae2591 
Fixes: quarkusio#38326
(cherry picked from commit 93167f0)
@michalvavrik @gsmet
Move RESTEasy Classic RBAC security checks to JAX-RS filter
1940eba 
(cherry picked from commit f850e7d35ba1f96b66be6686c7a9e34c7178450e)
@michalvavrik @gsmet
Fix JAX-RS default security checks for inherited / transformed endpoints
c026b1c 
(cherry picked from commit 4b559e9c6d2968cb2c37d66634e493f23fcbfead)
@gsmet gsmet added the area/infra internal and infrastructure related issues label Jan 26, 2024
@gsmet gsmet self-assigned this Jan 26, 2024
@quarkus-bot quarkus-bot bot added area/agroal area/arc Issue related to ARC (dependency injection) area/config area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/oidc area/platform Issues related to definition and interaction with Quarkus Platform area/resteasy-classic area/rest area/security labels Jan 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 26, 2024 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@gsmet
Copy link
Member Author

gsmet commented Jan 26, 2024

@cescoffier we have one test (https://github.com/quarkusio/quarkus/actions/runs/7668236045/job/20900122549?pr=38413) failing with the following which doesn't look good:

Caused by: io.grpc.StatusRuntimeException: UNKNOWN: jakarta.enterprise.inject.IllegalProductException - Normal scoped producer method may not return null: io.quarkus.vertx.http.runtime.CurrentVertxRequest.getCurrent()
	at io.grpc.Status.asRuntimeException(Status.java:537)
	at io.grpc.stub.ClientCalls$StreamObserverToCallListenerAdapter.onClose(ClientCalls.java:481)
	at io.grpc.PartialForwardingClientCallListener.onClose(PartialForwardingClientCallListener.java:39)
	at io.grpc.ForwardingClientCallListener.onClose(ForwardingClientCallListener.java:23)
	at io.grpc.ForwardingClientCallListener$SimpleForwardingClientCallListener.onClose(ForwardingClientCallListener.java:40)
	at io.quarkus.grpc.runtime.supports.IOThreadClientInterceptor$1$1.onClose(IOThreadClientInterceptor.java:72)
	at io.grpc.internal.DelayedClientCall$DelayedListener$3.run(DelayedClientCall.java:489)
	at io.grpc.internal.DelayedClientCall$DelayedListener.delayOrExecute(DelayedClientCall.java:453)
	at io.grpc.internal.DelayedClientCall$DelayedListener.onClose(DelayedClientCall.java:486)
	at io.grpc.internal.ClientCallImpl.closeObserver(ClientCallImpl.java:574)
	at io.grpc.internal.ClientCallImpl.access$300(ClientCallImpl.java:72)
	at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1StreamClosed.runInternal(ClientCallImpl.java:742)
	at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1StreamClosed.runInContext(ClientCallImpl.java:723)
	at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jan 26, 2024 •
edited by github-actions bot
Loading

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit e4e70f1 into quarkusio:3.7 Jan 27, 2024
53 checks passed
@mzellho
Copy link
Contributor

mzellho commented Jan 29, 2024

@gsmet: for what it's worth, in our project we also have some tests failing with the very same exception in 3.6.8 while 3.6.7 is fine.

@gsmet
Copy link
Member Author

gsmet commented Jan 29, 2024

@mzellho sorry, we thought 3.6 was fine. I will release 3.7 on Wednesday so I think I will avoid releasing yet another 3.6.

@gsmet
Copy link
Member Author

gsmet commented Jan 29, 2024

Hmmm, I thought about it a bit more and I'm considering pushing a new 3.6.

@gsmet gsmet mentioned this pull request Jan 29, 2024
Closed
@codespearhead codespearhead mentioned this pull request Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gsmet gsmet

Labels
area/agroal area/arc Issue related to ARC (dependency injection) area/config area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/infra internal and infrastructure related issues area/oidc area/platform Issues related to definition and interaction with Quarkus Platform area/rest area/resteasy-classic area/security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gsmet @mzellho @gastaldi @geoand @DavideD @aloubyansky @sberyozkin @michalvavrik