Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for WebSocket MaxFrameSize and MaxMessageSize #43435

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

dometec
Copy link

@dometec dometec commented Sep 23, 2024

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to add these there, but we need to think how we can advertize them from web-socket-next.

@mkouba WDYT?

(why it makes sense: because someone can use websockets directly from a router or reactive routes, it does not need to use Undertow websocket or websocket next).

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 23, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit cc761d5.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

🎊 PR Preview ffd0c78 has been successfully built and deployed to https://quarkus-pr-main-43435-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@mkouba
Copy link
Contributor

mkouba commented Sep 23, 2024

It makes sense to add these there, but we need to think how we can advertize them from web-socket-next.

We could just a section/note in the reference guide.

(why it makes sense: because someone can use websockets directly from a router or reactive routes, it does not need to use Undertow websocket or websocket next).

Well, it's possible but IMO not very common.

@cescoffier
Copy link
Member

Well, it's possible but IMO not very common.

The Dev UI uses a web socket. So, these configurations will affect it. It's not common, but we do use that approach.

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 23, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit cc761d5.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ Maven Tests - JDK 17

📦 integration-tests/devmode

io.quarkus.test.devui.DevUIHibernateOrmSmokeTest.testGetNumberOfEntityTypes - History

  • java.lang.RuntimeException: Failed to start quarkus - io.quarkus.dev.appstate.ApplicationStartException
io.quarkus.dev.appstate.ApplicationStartException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.dev.appstate.ApplicationStateNotification.waitForApplicationStart(ApplicationStateNotification.java:63)
	at io.quarkus.runner.bootstrap.StartupActionImpl.runMainClass(StartupActionImpl.java:142)
	at io.quarkus.deployment.dev.IsolatedDevModeMain.firstStart(IsolatedDevModeMain.java:91)
	at io.quarkus.deployment.dev.IsolatedDevModeMain.accept(IsolatedDevModeMain.java:428)
	at io.quarkus.deployment.dev.IsolatedDevModeMain.accept(IsolatedDevModeMain.java:55)
	at io.quarkus.bootstrap.app.CuratedApplication.runInCl(CuratedApplication.java:138)
	at io.quarkus.bootstrap.app.CuratedApplication.runInAugmentClassLoader(CuratedApplication.java:93)

⚙️ Maven Tests - JDK 17 Windows

📦 integration-tests/maven

io.quarkus.maven.it.TestMojoIT.testThatTheTestsAreReRunMultiModule - History

  • Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils.waitForNextCompletion(TestModeContinuousTestingMavenTestUtils.java:50)
	at io.quarkus.maven.it.LaunchMojoTestBase.testThatTheTestsAreReRunMultiModule(LaunchMojoTestBase.java:56)

@cescoffier cescoffier merged commit 8c53ac9 into quarkusio:main Sep 23, 2024
54 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 23, 2024
@cescoffier
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Max frame length of 65536 has been exceeded - Quarkus 3
3 participants