Fix nullpointer on null code websockets-next

[Malandril]

Fix nullpointer in ws-next basic connector when the websocket closeStatusCode is null.

[mkouba]

Did you actually observe a NPE in your app? Because the javadoc WebSocket.closeHandler(Handler<Void>) is pretty clear that "When the WebSocket received a close frame, the closeStatusCode() will return the status code and closeReason() will return the reason."

But maybe I just misundertood.

We could reuse the CloseReason.INTERNAL_SERVER_ERROR constant, i.e. something like:

CloseReason reason = CloseReason.INTERNAL_SERVER_ERROR;
if (ws.closeStatusCode() != null) {
   reason = new CloseReason(ws.closeStatusCode(), ws.closeReason());
}
doExecute(connection, reason, closeHandler);

WDYT?

[Malandril]

Did you actually observe a NPE in your app? Because the javadoc WebSocket.closeHandler(Handler<Void>) is pretty clear that "When the WebSocket received a close frame, the closeStatusCode() will return the status code and closeReason() will return the reason."

Yes for example closing a websocket server websocat with CTRL+C.
This is also being done in

quarkus/extensions/websockets-next/runtime/src/main/java/io/quarkus/websockets/next/runtime/WebSocketConnectionBase.java

Line 154 in 5725886

if (code == null) {

[mkouba]

Thanks!

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 1069847.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.