Add documentation for @WithTestResource to getting started testing #44685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
🙈 The PR is closed and the preview is expired. |
|
Thanks! I'll have a look tomorrow |
|
May I ask that the changes be limited to only what related to test resources? It makes reviewing stuff much easier. Thanks |
|
@geoand Sorry, that must have been some auto formatting. I'll revert that |
|
🙏🏽 |
HerrDerb
force-pushed
the
add-with-test-resource-documentation
branch
from
a250342 to
30f019b
Compare
geoand
added
the
triage/waiting-for-ci
Status for workflow
|
quarkus-bot
bot
removed
the
triage/waiting-for-ci
geoand
added
triage/waiting-for-ci
|
@geoand have you been aware of the TBD section? https://github.com/quarkusio/quarkus/pull/44685/files#diff-736ad6c4de04577ecfa48a1d44d6acaebb7ceac683ab1f51bdf30c7add9fe31cR1254 |
|
Oops, I missed that! I'll need to fix it |
geoand
added a commit
to geoand/quarkus
that referenced
this pull request
Nov 27, 2024
gsmet
added a commit
that referenced
this pull request
Nov 27, 2024
Address leftovers in testing docs from #44685
gsmet
pushed a commit
to gsmet/quarkus
that referenced
this pull request
Nov 27, 2024
(cherry picked from commit 107e4ea)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small draft for the usage of
@WithTestResourceas we got confused by how it works and finally switched back to@QuarkusTestResourceI just wrote down of what I think I know of reading the code 🙂I hope I did not get it completely wrong.
Please feel free to alter and add information, especially for the stuff of
BELOW TO EDIT:@WithTestResourceandTestResourceScope#44530