-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation, Manual, CLI #339
Comments
User manual and infrastructure added as of #401.
|
@svrotter You took notes on a couple bugs in the current manual (divergences between docs and code) and missing/tricky bits in the setup instructions, especially on windows. Could you post them here? |
We found some issues while trying to set up Stabilizer for local use on my Windows 10 machine with the Getting Started Guide. I try to give a brief overview of what we encountered:
We wanted to set everything up for local use, as I don't have access to "10.34.16.10" as a broker. I try to give a quick rundown of what we needed to do in order to make it work. Forgive me, if my terminology may be a bit inaccurate here but networking is really not my strength.
There were also some issues when trying to install miniconf. @jordens took over this part, so I just write down his bash history more or less. All commands were executed in MING64 bash in the Stabilizer repo, while he created a virtual python environment vpy first: |
452: Documentation updates r=ryan-summers a=ryan-summers This PR fixes a variety of issues noted in #339 (comment) This PR also fixes #449 by adding a `.gitattributes` file that forces the mosquitto config file to be checked out with LF line endings. It appears more recent versions of mosquitto require this. Co-authored-by: Ryan Summers <ryan.summers@vertigo-designs.com>
451: Feature/dual iir config script r=jordens a=ryan-summers This PR addresses #339 by adding a CLI for configuring dual-iir's filter channels. Currently, the following filters have been added: * All-pass * High-pass * Low-pass * Notch The following controllers are also supported: * PID * PII It may also be desired to generate a bode plot of the generated filter for the user upon request. TODO: - [x] Update docs to point to this script - [x] Update CI to run pylint on `scripts/` directory - [x] Merge/update Miniconf quartiq/miniconf#53, update TOML - [x] Test PII/PID controllers Co-authored-by: Ryan Summers <ryan.summers@vertigo-designs.com>
Just found https://github.com/airwoodix/sinara-stabilizer-notes from @airwoodix.
filter_design.py
can be polished up a little and upstreamed here as a first-class user facing CLI for dual-iir. It's also a nice show case for rough edges or missing pieces in the API.filter_design
and and Preparation -> README or other docs structure rustdoc?)The text was updated successfully, but these errors were encountered: