Feature/adc dac io macros #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordens
force-pushed
the
feature/adc-dac-io-macros
branch
from
cd555b8
to
ab50f55
Compare
I believe this is a bug in the DAC outputs - these DMA streams should not be operating in circular mode. I believe it's not currently causing incorrect output because we schedule a new DMA transfer as soon as the last one completes, so the circular transfer configuration never gets a chance to generate incorrect data. However, this should be removed. I'll open an issue. |
|
Then that's a copy-paste bug par excellence, found and fixed by "don't repeat yourself" ;) |
ryan-summers
requested changes
Nov 30, 2020
…macros * origin/master: more nightly clippy lints clippy lints gha: clippy-check build(deps): bump paste from 1.0.2 to 1.0.3 build(deps): bump panic-semihosting from 0.5.4 to 0.5.6
ryan-summers
requested changes
Dec 2, 2020
* master: cargo: add docs for target cpu/features iir: more generic math helpers, use core::intrinsics cargo fmt [nfc] iir: vminnm/vmaxnm iir: fmt [nfc] iir: fix comment [nfc] cargo-config: cm7 features iir: copy_within is better than rotate_right processing: use faster unsafe truncate
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to try macros.
This moves the ADC and DAC DMA setup into macros reducing code footprint. Hopefully no functional changes there.
I didn't test this on hardware and I may have missed differences between
Adc0/Adc1andDac0/Dac1.It removes the
AdcInputsandDacOutputsstructs and replaces them with tuples as they were just fan-outs/fan-ins.It also does some minor tweaks in the
process()ISR towards higher flexibility enforces some data patterns to help the compiler.Differences missing:
.transfer_complete_interrupt(true)forAdc1only: needed.circular_buffer(true);forDac1only: close DAC1 DMA stream operates in circular mode #183