Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT settings and telemetry #261

Merged
merged 32 commits into from
Feb 19, 2021
Merged

MQTT settings and telemetry #261

merged 32 commits into from
Feb 19, 2021

Conversation

ryan-summers
Copy link
Member

@ryan-summers ryan-summers commented Feb 3, 2021

This PR replaces #242

This PR addresses #149 by exposing a simple MQTT-based settings interface

TODO:

  • Resolve mutable ownership issues in the MqttInterface
  • Expand settings interface to lockin.rs
  • Add all settings (not yet supported by miniconf)
  • Finalize and publish the miniconf package Deferred to the future.
  • Move MqttInterface-like behaviors over to miniconf
  • Move smoltcp-nal to a separate crate
  • Test on hardware
  • Implement stabilizer telemetry: Deferred to future

@ryan-summers ryan-summers mentioned this pull request Feb 3, 2021
8 tasks
@jordens
Copy link
Member

jordens commented Feb 17, 2021

If there is an ergonomic advantage over using raw mqtt CLI utilities, let's also do a minimal CLI example client implementation for the IIR parameters in dual-iir.

Cargo.toml Outdated Show resolved Hide resolved
dsp/Cargo.toml Outdated Show resolved Hide resolved
src/bin/dual-iir.rs Show resolved Hide resolved
src/bin/dual-iir.rs Outdated Show resolved Hide resolved
src/bin/lockin-external.rs Outdated Show resolved Hide resolved
src/hardware/cycle_counter.rs Show resolved Hide resolved
dsp/src/iir.rs Outdated Show resolved Hide resolved
dsp/Cargo.toml Outdated Show resolved Hide resolved
src/bin/lockin-external.rs Outdated Show resolved Hide resolved
@ryan-summers
Copy link
Member Author

I have bench tested setting various values of dual-iir, such as the IIR y_offset parameter and the AFE gain. Everything appears to be in working order for merging.

@ryan-summers
Copy link
Member Author

bors merge

@jordens
Copy link
Member

jordens commented Feb 19, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 19, 2021

Already running a review

@bors
Copy link
Contributor

bors bot commented Feb 19, 2021

Build succeeded:

@bors bors bot merged commit bfb416b into master Feb 19, 2021
@bors bors bot deleted the feature/mqtt-convert branch February 19, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants