rj/miniconf #374
Merged
rj/miniconf #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jordens
commented
Jun 1, 2021
jordens
commented
- miniconf.py: make retain an option
- miniconf: add some checks, simplify
ryan-summers
requested changes
Jun 3, 2021
There was a problem hiding this comment.
One minor doc update. Otherwise, LGTM. Definitely makes sense to use just a raw int for now, and we can always change in the future if we want more complex correlation data, since that's all at our layer and unrelated to the firmware (whatever we send gets echo'd).
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.