Updating to HAL mainline #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jordens
requested changes
Jun 15, 2021
jordens
approved these changes
Jun 15, 2021
bors bot
added a commit
that referenced
this pull request
Jun 21, 2021
380: Adding data livestream capability r=ryan-summers a=ryan-summers This PR implements livestream capability for ADC and DAC samples. The current implementation provides a static configuration. **TODO** - [x] Clean up documentation - [x] Implement streaming for `lockin` app - [x] Test new block-packetization scheme - [x] Add reference python stream receiver - [x] Merge #381 first Co-authored-by: Ryan Summers <ryan.summers@vertigo-designs.com>
bors bot
added a commit
that referenced
this pull request
Jun 21, 2021
380: Adding data livestream capability r=ryan-summers a=ryan-summers This PR implements livestream capability for ADC and DAC samples. The current implementation provides a static configuration. **TODO** - [x] Clean up documentation - [x] Implement streaming for `lockin` app - [x] Test new block-packetization scheme - [x] Add reference python stream receiver - [x] Merge #381 first Co-authored-by: Ryan Summers <ryan.summers@vertigo-designs.com>
bors bot
added a commit
that referenced
this pull request
Jun 21, 2021
380: Adding data livestream capability r=ryan-summers a=ryan-summers This PR implements livestream capability for ADC and DAC samples. The current implementation provides a static configuration. **TODO** - [x] Clean up documentation - [x] Implement streaming for `lockin` app - [x] Test new block-packetization scheme - [x] Add reference python stream receiver - [x] Merge #381 first Co-authored-by: Ryan Summers <ryan.summers@vertigo-designs.com>
bors bot
added a commit
that referenced
this pull request
Jun 21, 2021
380: Adding data livestream capability r=ryan-summers a=ryan-summers This PR implements livestream capability for ADC and DAC samples. The current implementation provides a static configuration. **TODO** - [x] Clean up documentation - [x] Implement streaming for `lockin` app - [x] Test new block-packetization scheme - [x] Add reference python stream receiver - [x] Merge #381 first Co-authored-by: Ryan Summers <ryan.summers@vertigo-designs.com>
bors bot
added a commit
that referenced
this pull request
Jun 22, 2021
380: Adding data livestream capability r=ryan-summers a=ryan-summers This PR implements livestream capability for ADC and DAC samples. The current implementation provides a static configuration. **TODO** - [x] Clean up documentation - [x] Implement streaming for `lockin` app - [x] Test new block-packetization scheme - [x] Add reference python stream receiver - [x] Merge #381 first Co-authored-by: Ryan Summers <ryan.summers@vertigo-designs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates to utilize latest version of the HAL (in anticipation of bumping smoltcp). Updates are only around SPI CS control, and I think the new API, while a little distasteful in syntax, is more expressive and useful.
I've tested this on loopback hardware with a 1KHz 1V sinusoid and confirmed things look as expected.