Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup: use a best-effort lock for rprintln #391

Merged
merged 2 commits into from
Jun 24, 2021
Merged

setup: use a best-effort lock for rprintln #391

merged 2 commits into from
Jun 24, 2021

Conversation

jordens
Copy link
Member

@jordens jordens commented Jun 24, 2021 •
edited
Loading

close #382

  • tested with very long log messages that would otherwise cause the DMA deadline to be missed. (use cargo-embed git to make it work with stlink v3)

ryan-summers
ryan-summers approved these changes Jun 24, 2021
View reviewed changes
Copy link
Member

@ryan-summers ryan-summers left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I agree with the ordering semantics used for the atomic load/store operations being Acquire/Release.

@ryan-summers
Copy link
Member

Bors r+

@bors
Copy link
Contributor

bors bot commented Jun 24, 2021

Build succeeded:

@bors bors bot merged commit b7e2a3d into master Jun 24, 2021
@bors bors bot deleted the rj/best-effort-rprintln branch June 24, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan-summers ryan-summers ryan-summers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logging messages may cause DSP timing to be missed
2 participants
@jordens @ryan-summers