Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tighten signal_generator symmetry bounds #410

Merged
merged 4 commits into from
Jul 21, 2021
Merged

tighten signal_generator symmetry bounds #410

merged 4 commits into from
Jul 21, 2021

Conversation

jordens
Copy link
Member

@jordens jordens commented Jul 20, 2021 •
edited
Loading

close #408

ryan-summers
ryan-summers requested changes Jul 21, 2021
View reviewed changes
src/hardware/signal_generator.rs Outdated Show resolved Hide resolved
@ryan-summers ryan-summers linked an issue Jul 21, 2021 that may be closed by this pull request
signal_generator: validate symmetry #408
Closed
@jordens jordens changed the title fix 408 tighten signal_generator symmetry bounds Jul 21, 2021
@ryan-summers
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jul 21, 2021
@bors @jordens
Merge #410
8167817 
410: tighten signal_generator symmetry bounds r=ryan-summers a=jordens

close #408 

Co-authored-by: Robert Jördens <rj@quartiq.de>
@jordens
Copy link
Member Author

jordens commented Jul 21, 2021

need to add another check
bors cancel

@bors
Copy link
Contributor

bors bot commented Jul 21, 2021

Canceled.

@jordens
Copy link
Member Author

jordens commented Jul 21, 2021

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 21, 2021

Build succeeded:

@bors bors bot merged commit 9366709 into master Jul 21, 2021
@bors bors bot deleted the rj/fix-408 branch July 21, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan-summers ryan-summers Awaiting requested review from ryan-summers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

signal_generator: validate symmetry
2 participants
@jordens @ryan-summers