-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add adc fix from driver #584
Conversation
Hmm, let me quickly check about the other channels. |
Ok, I've confirmed that exactly these changes lead to the external inputs being very accurate. Without the changes we have the same ~3% error observed before. |
That means that the CPU temp readings have an additional, probably unrelated issue. |
Hmm, then perhaps the ADC clock is not the only issue with CPU measurement stability. I'll open up an issue. |
Ack. But then we should land this. |
Build succeeded: |
Very small PR to fix the internal ADCs by setting the clock prescalers and then recalibrating. Code from the
driver
branch.