Adding initial support for configuring parameters via USB #805
Conversation
There was a problem hiding this comment.
@jordens This is now a functional implementation. A lot of this could easily be abstracted out into a separate crate that we could share between stabilizer/booster/thermostat as well. My only current question is figuring out how to be generic over the flash settings structure. It's a similar problem to miniconf, but subtley different.
Alternatively, if we don't really care about losing settings when the settings structure is modified, we could just serialize the whole structure directly into flash, or we could implement update management directly in firmware.
src/hardware/serial_terminal.rs
Outdated
| items: &[ | ||
| &menu::Item { | ||
| command: "reset", | ||
| help: Some("Reset Stabilizer to force new settings to take effect."), |
There was a problem hiding this comment.
- Let's make this already device and application agnostic.
s/Stabilizer/device. - Let's also add a command that resets the settings to their default (and distinguish clearly which command resets the CPU and which resets the settings).
- Does the term
propertymatch the term we use inminiconf? I think there it'sitem. - Let's also state clearly here that these settings here are distinct from the application
mqttsettings. Let's open an issue to discuss how we can use/expose the application settings through usb and save/load them in flash to be overriden by mqtt. - Also I'd like to consider making this menu interface to miniconf (plus maybe persistent storage) a agnostic thing (crate).
| _args: &[&str], | ||
| context: &mut Context, | ||
| ) { | ||
| writeln!(context, "Available properties:").unwrap(); |
There was a problem hiding this comment.
Can this also print the docstring (or some other struct-associated string) of the settings struct?
There was a problem hiding this comment.
Right now, no. I think we could expand the miniconf macro to expose the docstrings as metadata as well, but that would be a modification of miniconf. I'll open an issue.
There was a problem hiding this comment.
I added quartiq/miniconf#187 for this functionality
There was a problem hiding this comment.
I meant just the docstring of the struct, not of the fields. That would already cover a lot.
This PR fixes #351 by storing the MQTT broker address and the stabilizer ID in the unused flash bank.
TODO: