Adding usage of sequential storage #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-summers
force-pushed
the
feature/sequential-storage
branch
from
dbc90ba
to
0b2c98c
Compare
jordens
previously approved these changes
Dec 4, 2023
There was a problem hiding this comment.
@ryan-summers I reworked the save logic a bit.
LGTM.
Sidenote: While a hypothetical TreeKey::iter_indices() would make the storage more compact, it would make it less robust against settings struct changes (as the indices are not necessarily very stable).
ryan-summers
force-pushed
the
feature/sequential-storage
branch
from
02323b0
to
8bc4d84
Compare
|
I was in the process of reorganizing and writing docs when you pushed your change, but I've incorporated them into the PR. Let me know if things look good! |
jordens
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leveraging
sequential-storageto make it faster to save settings and reduce wear on the flash. This PR also makes it so that the flash settings structure is not defined in flash itself, so if we add new items in the future, they will be dynamically loaded into the settings struct. This ensures that settings will not be lost between API changes.This also aids in supporting #822, as we can encode the settings item-by-item into the flash memory. This also means that settings for different profiles can co-exist (as long as they have unique settings names) so that they persist (and are shared) between different applications.