Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression 2.17.0 in QSelect when map-options are true and options are null. #17613

Closed
hazzik opened this issue Oct 31, 2024 · 1 comment
Closed
Labels
area/components bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-webpack kind/bug 🐞 Qv2 🔝 Quasar v2 issues

Comments

@hazzik
Copy link
Contributor

hazzik commented Oct 31, 2024

What happened?

Updated to 2.17.0, many QSelect components stopped working. Likely a regression in this commit: d044fdd

What did you expect to happen?

Not throwing TypeError

Reproduction URL

https://codepen.io/hazzik/pen/OJKZjyM

How to reproduce?

<q-select map-options :options="null" />

Flavour

Quasar CLI with Webpack (@quasar/cli | @quasar/app-webpack)

Areas

Components (quasar)

Platforms/Browsers

Chrome, Microsoft Edge

Quasar info output

Global packages
  NPM - 10.8.2
  yarn - 1.22.22
  @quasar/cli - undefined
  @quasar/icongenie - Not installed
  cordova - Not installed

Important local packages
  quasar - 2.17.1 -- Build high-performance VueJS user interfaces (SPA, PWA, SSR, Mobile and Desktop) in record time
  @quasar/app-webpack - 3.14.0 -- Quasar Framework App CLI with Webpack
  @quasar/extras - 1.16.12 -- Quasar Framework fonts, icons and animations
  eslint-plugin-quasar - Not installed
  vue - 3.5.11 -- The progressive JavaScript framework for building modern web UI.
  vue-router - 4.4.3
  pinia - Not installed
  vuex - 4.1.0 -- state management for Vue.js
  electron - Not installed
  electron-packager - Not installed
  @electron/packager - Not installed
  electron-builder - Not installed
  @babel/core - 7.24.8 -- Babel compiler core.
  webpack - 5.94.0 -- Packs ECMAScript/CommonJs/AMD modules for the browser. Allows you to split your codebase into multiple bundles, which can be loaded on demand. Supports loaders to preprocess files, i.e. json, jsx, es7, css, less, ... and your custom stuff.
  webpack-dev-server - 4.11.1 -- Serves a webpack app. Updates the browser on changes.
  workbox-webpack-plugin - Not installed
  register-service-worker - 1.7.2 -- Script for registering service worker, with hooks
  typescript - 4.9.4 -- TypeScript is a language for application scale JavaScript development
  @capacitor/core - Not installed
  @capacitor/cli - Not installed
  @capacitor/android - Not installed
  @capacitor/ios - Not installed

Quasar App Extensions
  @quasar/quasar-app-extension-qpdfviewer - 2.0.0-alpha.6 -- QPdfviewer is an app extension for viewing PDF files

Relevant log output

QSelect.js:612  Uncaught (in promise) TypeError: Cannot read properties of null (reading 'find')
    at getOption (QSelect.js:612:28)
    at QSelect.js:207:37
    at Array.map (<anonymous>)
    at ComputedRefImpl.fn (QSelect.js:207:28)
    at refreshComputed (reactivity.esm-bundler.js:377:1)
    at get value [as value] (reactivity.esm-bundler.js:1693:1)
    at ReactiveEffect.getter [as fn] (reactivity.esm-bundler.js:1791:1)
    at ReactiveEffect.run (reactivity.esm-bundler.js:222:1)
    at job (reactivity.esm-bundler.js:1861:1)
    at watch (reactivity.esm-bundler.js:1911:1)

Additional context

Working fine in 2.16.x: https://codepen.io/hazzik/pen/YzmLxym

@hazzik hazzik added kind/bug 🐞 Qv2 🔝 Quasar v2 issues labels Oct 31, 2024
@github-actions github-actions bot added area/components bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-webpack labels Oct 31, 2024
@hazzik hazzik changed the title Regression 2.17.0 in QSelect when map-options are true and options are null. Regression 2.17.0 in QSelect when map-options are true and options are null. Oct 31, 2024
@rstoenescu
Copy link
Member

Fix will be available in Quasar v2.17.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/components bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-webpack kind/bug 🐞 Qv2 🔝 Quasar v2 issues
Projects
None yet
Development

No branches or pull requests

2 participants