Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded english in DataTable #284

Closed
caex opened this issue Dec 27, 2016 · 2 comments
Closed

Hardcoded english in DataTable #284

caex opened this issue Dec 27, 2016 · 2 comments
Milestone

Comments

@caex
Copy link

caex commented Dec 27, 2016

Hello,

just integrated the DataTable component and it's great.
However one problem is the hardcoded english, unfortunately my WebApp is in french.

There are the culprits :
(DataTable.vue line 20)

static-label="Columns"

(lines 30-31)

{{ rowsSelected }} item<span v-show="rowsSelected > 1">s</span> selected.
  <button class="primary clear small" @click="clearSelection()">Clear</button>

(TablePagination.vue line 4)

Rows

Would be great if we could customize it through Props or Slots.

Or to have just one lang="en" prop and let the community build a language file for each language, with fallback to english 👍

Cheers

@rstoenescu
Copy link
Member

Yes, part of Internationalization #100 . Will soon be fixed.

@rstoenescu
Copy link
Member

Internationalization as a whole might take a while, so adding config.labels to handle this.

@rstoenescu rstoenescu added this to the v0.12 milestone Dec 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants