Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds new-value to QSelect emits #10991

Closed
wants to merge 1 commit into from
Closed

adds new-value to QSelect emits #10991

wants to merge 1 commit into from

Conversation

benkroeger
Copy link

this actually causes a warning in development mode. see vuejs/core#4803 for details

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: avoids warning when emitting custom event

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
This is actually a cosmetic change - since the related fix have been proposed to vue as well. But i's nice to list custom events in a component's emits prop

this actually causes a warning in development mode. see vuejs/core#4803 for details
@rstoenescu
Copy link
Member

Hi,

Thanks for contributing, but this is a Vue bug and the correct way is to wait for it to be fixed rather than work around it from Quasar core.

@rstoenescu rstoenescu closed this Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants