Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate ecosystem-ci scripts to pnpm #17003

Merged

Conversation

haoqunjiang
Copy link
Contributor

@haoqunjiang haoqunjiang commented Mar 14, 2024

There's no pnpm workspace command. Instead, pnpm uses the --filter option to run a command in a specific workspace package.

Note there will always be an "ELIFECYCLE Command failed." message at the end of the vite-plugin test.
But that's from the vite preview server being stopped after a successful test run. It's not a real error and doesn't affect the test result or the exit code.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

There's no `pnpm workspace` command. Instead, pnpm uses the `--filter`
option to run a command in a specific workspace.

Note there will always be a "ELIFECYCLE Command failed." message at the
end of the vite-plugin test.
But that's from the vite preview server being stopped after a successful
test run. It's not a real error and doesn't affect the test result or
the exit code.
@yusufkandemir
Copy link
Member

I overlooked those scripts while migrating to pnpm, thanks for the fix.

@yusufkandemir yusufkandemir merged commit 53c2364 into quasarframework:dev Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants