Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in Qdate using direction #17145

Merged
merged 3 commits into from
Apr 27, 2024
Merged

Bugfix in Qdate using direction #17145

merged 3 commits into from
Apr 27, 2024

Conversation

zanzara
Copy link
Contributor

@zanzara zanzara commented Apr 26, 2024

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

Copy link

UI Tests Results

    1 files     73 suites   26s ⏱️
1 075 tests 1 075 ✅ 0 💤 0 ❌
1 094 runs  1 094 ✅ 0 💤 0 ❌

Results for commit 0149d6c.

@rstoenescu rstoenescu merged commit de0a91f into quasarframework:dev Apr 27, 2024
2 checks passed
@rstoenescu
Copy link
Member

Wow. Not sure how this slipped for this long.
The direction should in fact be a computed prop so that it reacts to lang.rtl. Changed it in your PR.

Thanks for contributing!

@zanzara
Copy link
Contributor Author

zanzara commented Apr 27, 2024

Wow. Not sure how this slipped for this long. The direction should in fact be a computed prop so that it reacts to lang.rtl. Changed it in your PR.

Thanks for contributing!

Oh sure, I should have that in mind , that direction has to be aswell a computed as the majority of other props.
But on first sight, I only saw that .value cannot be right there.

It had jumped into my eyes after having sm investigations to that FR: #16632
But this FR seems to be very "complex" to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants