-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow custom value for QSelect and QDialogSelect #589
feat: Allow custom value for QSelect and QDialogSelect #589
Conversation
Hi, let's find a better name for this prop and merge the PR. "custom-value" is a little bit confusing. Anyone got any ideas? |
Wouldn't this be something userland could do on their own with a computed property? Scott |
It can be computed in userland, this is just the glue to allow it to be displayed. The name was a derivate of actualValue. Maybe the old staticLabel is better? |
@pdanpdan Good 'ol |
value-converter or value-conversion ??? 😄 Scott |
|
Sounds good to me! Scott |
@pdanpdan does |
Yes, it sounds good. |
Ok, then let's do it like this. |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch and not themaster
branchfix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
For select components sometimes one needs to provide a shorter or different custom value.
Like the number of selected items in case of a lot of options selected.
Unified the actualValue code in QSelect and QDialogSelect. Maybe it should be extracted in select-mixin.