Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code style update #607

Merged
merged 13 commits into from
May 31, 2017
Merged

Code style update #607

merged 13 commits into from
May 31, 2017

Conversation

ceau
Copy link
Contributor

@ceau ceau commented May 31, 2017

What kind of change does this PR introduce? (check at least one)

  • Code style update

Does this PR introduce a breaking change? (check one)

  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested with all Quasar themes
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@rstoenescu rstoenescu merged commit 558e6f6 into quasarframework:dev May 31, 2017
@rstoenescu
Copy link
Member

Nice PR! Thanks!

@ceau
Copy link
Contributor Author

ceau commented May 31, 2017

I like the framework, I want to contribute to it.the project is very nice, I hope it well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants