Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX: fix bug with q-parallax when using ssr #7196

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

SeanDylanGoff
Copy link
Contributor

@SeanDylanGoff SeanDylanGoff commented Jun 9, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

This is how QParallax looks when activating SSR ("quasar dev -m ssr" latest chrome, mobile and desktop). I made the pull request to master because I think this fix should be considered a hotfix. correct me if i'm wrong :)

image

@rstoenescu rstoenescu merged commit 6fa7e14 into quasarframework:master Jun 10, 2020
@rstoenescu
Copy link
Member

Thanks for contributing!
One thing missing: the equivalent QParallax.styl change -- will do it right now.

This will go into v1.12.5.

@rstoenescu
Copy link
Member

Also noticed the "master" branch. It should be done on "dev" branch.

rstoenescu added a commit that referenced this pull request Jun 10, 2020
rstoenescu added a commit that referenced this pull request Jan 22, 2021
* cs (czech) lang (#1874)

Hi guys, here is PR for Czech language :)

* fix bug with q-parallax when using ssr (#7196)

* Docs: Add an api instance to avoid insecure assignment of access tokens

This change adds consistency across axios boot files examples in docs,
and makes the default examples less error prone from unintentional
inclusion of Authorization tokens to 3rd party services

* Add some Markdown 'js' highlight types on code blocks, and closing brace

* Update ajax-requests.md

* Update boot-files.md

Co-authored-by: VonSandberg <nahlovsky.j@gmail.com>
Co-authored-by: Razvan Stoenescu <razvan.stoenescu@gmail.com>
Co-authored-by: SeanDylanGoff <sean318@hotmail.ch>
Co-authored-by: Allan Gaunt <allangaunt@gmail.com>
rstoenescu added a commit that referenced this pull request Jan 22, 2021
* cs (czech) lang (#1874)

Hi guys, here is PR for Czech language :)

* fix bug with q-parallax when using ssr (#7196)

* Docs: Add an api instance to avoid insecure assignment of access tokens

This change adds consistency across axios boot files examples in docs,
and makes the default examples less error prone from unintentional
inclusion of Authorization tokens to 3rd party services

* Add some Markdown 'js' highlight types on code blocks, and closing brace

* Update ajax-requests.md

* Update boot-files.md

Co-authored-by: VonSandberg <nahlovsky.j@gmail.com>
Co-authored-by: Razvan Stoenescu <razvan.stoenescu@gmail.com>
Co-authored-by: SeanDylanGoff <sean318@hotmail.ch>
Co-authored-by: Allan Gaunt <allangaunt@gmail.com>
rstoenescu added a commit that referenced this pull request Apr 25, 2021
* cs (czech) lang (#1874)

Hi guys, here is PR for Czech language :)

* fix bug with q-parallax when using ssr (#7196)

* Remove deprecated dependences

April 7, 2021: The NPM package for this package has been deprecated and the Github repo archived.

Co-authored-by: VonSandberg <nahlovsky.j@gmail.com>
Co-authored-by: Razvan Stoenescu <razvan.stoenescu@gmail.com>
Co-authored-by: SeanDylanGoff <sean318@hotmail.ch>
Co-authored-by: Allan Gaunt <allangaunt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants