Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marketplace: check for terminated subscriptions when fetching details (PROJQUAY-7035) #2834

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

Marcusk19
Copy link
Contributor

If a subscription is deleted in the subscription watch API it will set the field terminatedDate for the subscription object. This should be taken into consideration when fetching a subscription's details and the subscription should be removed from an org if it is terminated like how we already do for expired subscriptions.

Copy link
Member

@kleesc kleesc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Marcusk19 Marcusk19 enabled auto-merge (squash) May 15, 2024 13:36
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.90%. Comparing base (65e7270) to head (97dd161).
Report is 2 commits behind head on master.

Files Patch % Lines
endpoints/api/billing.py 60.00% 0 Missing and 2 partials ⚠️
util/marketplace.py 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2834   +/-   ##
=======================================
  Coverage   70.90%   70.90%           
=======================================
  Files         437      437           
  Lines       40852    40860    +8     
  Branches     5354     5355    +1     
=======================================
+ Hits        28966    28973    +7     
- Misses      10190    10191    +1     
  Partials     1696     1696           
Flag Coverage Δ
unit 70.90% <73.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Marcusk19 Marcusk19 merged commit 1cc6d52 into quay:master Jun 6, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants