Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: overview page fixes (PROJQUAY-7107) #2843

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

dmesser
Copy link
Contributor

@dmesser dmesser commented Apr 26, 2024

This fixes a range of smaller issues with the overview page:

  • Dark Mode is not supported well (some black text on dark background)
  • Incorrect links directly to Quay.io, which leave the Cloud Console
  • lack of vertical padding in the pricing tab
  • some language on the call to actions
  • low res screenshot of Quay UI (now also alternating depending dark/light theme selection)

Screenshot 2024-04-26 at 13 57 29
Screenshot 2024-04-26 at 13 57 38
Screenshot 2024-04-26 at 13 57 57

Signed-off-by: dmesser <dmesser@redhat.com>
Signed-off-by: dmesser <dmesser@redhat.com>
Signed-off-by: dmesser <dmesser@redhat.com>
Signed-off-by: dmesser <dmesser@redhat.com>
@dmesser
Copy link
Contributor Author

dmesser commented Apr 26, 2024

The Cypress test is failing because the default security policies probably prevent us from writing into the clipboard in Chrome at CI runtime. This is addressed in #2840

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.92%. Comparing base (4bfad98) to head (b1411cc).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2843      +/-   ##
==========================================
- Coverage   70.93%   70.92%   -0.01%     
==========================================
  Files         436      436              
  Lines       40723    40735      +12     
  Branches     5323     5328       +5     
==========================================
+ Hits        28887    28892       +5     
- Misses      10152    10157       +5     
- Partials     1684     1686       +2     
Flag Coverage Δ
unit 70.92% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bcaton85 bcaton85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmesser dmesser merged commit 17c41ff into quay:master Apr 26, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants