Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[redhat-3.12] logging: hide entries when debuglog is set to false and add missing worker names (PROJQUAY-6562) #3206

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

sayalibhavsar
Copy link
Contributor

This is a manually cherry pick of #3193

Copy link
Contributor

@Marcusk19 Marcusk19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.45%. Comparing base (2928153) to head (2f94bb2).
Report is 1 commits behind head on redhat-3.12.

Files with missing lines Patch % Lines
util/migrate/allocator.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           redhat-3.12    #3206   +/-   ##
============================================
  Coverage        70.44%   70.45%           
============================================
  Files              440      440           
  Lines            41524    41531    +7     
  Branches          5446     5446           
============================================
+ Hits             29251    29259    +8     
  Misses           10553    10553           
+ Partials          1720     1719    -1     
Flag Coverage Δ
unit 70.45% <88.88%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sayalibhavsar sayalibhavsar merged commit 3ddee70 into quay:redhat-3.12 Sep 10, 2024
18 checks passed
@sayalibhavsar sayalibhavsar deleted the redhat-3.12 branch October 23, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants