Trigger maven CI action upon push to main #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkleedorfer
requested review from
steveraysteveray,
ralphtq and
jhodgesatmb
as code owners
steveraysteveray
approved these changes
Dec 5, 2024
|
Ah sorry, forgot about that - we can do this... PR coming up |
|
PR is here #1054 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last change to the maven CI action removed the
pushtrigger. This resulted in the action not being executed on the main branch when a PR was rebased onto main.This PR reintroduces the
pushevent as a trigger and limits it to themainbranch, so it does not trigger the action upon push to any branch. Hopefully this leads to the action running on the main branch after a PR merge. Direct pushes tomainare not allowed, so there should not be any other effect.