add SHACL definition validation in CI #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimkont
requested review from
steveraysteveray,
ralphtq,
jhodgesatmb and
fkleedorfer
as code owners
|
Yes, the format plugin removes any comments. Future work. |
|
Love this, btw! |
fkleedorfer
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some invalid SHACL declarations in the constraint definition. With this PR, I removed them and, additionally, added validation of all the SHACL files using shacl-shacl. The format plugin did not let me keep some comments on the
SHACL-SHACL.ttlfile wrt origin, not sure if you want to add some details in a readme file or if it is ok as is