Removed unit:CFU #1066
Merged
Removed unit:CFU #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveraysteveray
requested review from
ralphtq,
jhodgesatmb and
fkleedorfer
as code owners
fkleedorfer
approved these changes
Dec 6, 2024
|
I'm thinking that when we migrate to QUDT 3.0 we would use that occasion to delete all the deprecated entities. We would have to all agree on that of course. But your larger point, definitely worth considering. I'm going to go ahead and merge for now. |
|
@fkleedorfer, this PR indicates the check passed, but under the Actions tab it looks like it fails because it was unable to delete the snapshot release. Also, I notice there is no longer a snapshot listed as a Release any more. Is this what you expect? |
|
Well this deleting the release step has never run before. Now that it actually runs, we see it is somehow wrong. Next pr to the rescue. Sorry for the inconvenience |
|
No apologies! The test loop is a slow one here... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.