Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make delim a keyword argument #16

Closed
davidanthoff opened this issue Jan 10, 2018 · 2 comments · Fixed by #60
Closed

Make delim a keyword argument #16

davidanthoff opened this issue Jan 10, 2018 · 2 comments · Fixed by #60
Labels
enhancement
Milestone
Backlog

Comments

@davidanthoff
Copy link
Member

No description provided.

@davidanthoff davidanthoff added this to the Backlog milestone Jan 10, 2018
@zweiglimmergneis
Copy link

It would be really good, having load working properly with delim as a keyword argument, as it is claimed in the documentation. Let me know if this can be done in reasonable time by a person like me, working with julia at a user level until now.

@davidanthoff
Copy link
Member Author

Yes, this should actually be a really simple change: we just have to change the four fileio_load functions here so that delim is no longer an optional, but instead a keyword argument.

And then update tests etc., but in general this should be a simple change. A PR would be very welcome!

zweiglimmergneis added a commit to zweiglimmergneis/CSVFiles.jl that referenced this issue Nov 13, 2018
@zweiglimmergneis
CSVFiles: make delim a keyword argument in load
3a87378 
See issue queryverse#16.

`load` accepts `delim` as a keyword argument for CSV files and/or TSV files. The delimiting character may also be specified as the second positional argument (as before).
@zweiglimmergneis zweiglimmergneis mentioned this issue Nov 13, 2018
Closed
@davidanthoff davidanthoff mentioned this issue Aug 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Make delim a keyword argument queryverse/CSVFiles.jl
2 participants
@davidanthoff @zweiglimmergneis