Add a..b syntax #121
Merged
Add a..b syntax #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxinabox
reviewed
Jun 23, 2017
|
|
||
| for i in 1:length(qe) | ||
| qe[i] = postwalk(qe[i]) do x | ||
| if x isa Expr && x.head==:call && x.args[1]==:(..) |
There was a problem hiding this comment.
Could this be written
if @capture(x, x_..y_)
:(map(i->i.$y, x))
else
x
end
My MacroTools.jl foo isn't that strong so maybe I am wrong about this
There was a problem hiding this comment.
It might well be, but my MacroTools.jl foo is almost non-existent and I know the current formulation works, so I'm tempted to just leave as is ;)
added example and test for a..b
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
==========================================
+ Coverage 82.15% 82.64% +0.49%
==========================================
Files 21 21
Lines 807 801 -6
==========================================
- Hits 663 662 -1
+ Misses 144 139 -5
Continue to review full report at Codecov.
|
This reverts commit 8358384.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This translates any
a..bin a query intomap(i->i.b, a).Needs