Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly tweak the API #5

Merged
merged 1 commit into from
Aug 6, 2019
Merged

Slightly tweak the API #5

merged 1 commit into from
Aug 6, 2019

Conversation

davidanthoff
Copy link
Member

Do you think this makes sense?

I mostly care about the final API, i.e. I think it would be good if both

db = Database(filename)

and

db = Database(SQLite.DB(filename))

worked.

I think SourceTables is too opaque of a name for end users.

@davidanthoff davidanthoff added the enhancement New feature or request label Aug 6, 2019
@codecov-io
Copy link

codecov-io commented Aug 6, 2019

Codecov Report

Merging #5 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage    69.5%   69.65%   +0.15%     
==========================================
  Files           8        8              
  Lines         200      201       +1     
==========================================
+ Hits          139      140       +1     
  Misses         61       61
Impacted Files Coverage Δ
src/QuerySQLite.jl 100% <ø> (ø) ⬆️
src/library.jl 61.11% <ø> (ø) ⬆️
src/source.jl 73.68% <100%> (+1.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5c863a...858f848. Read the comment docs.

@bramtayl bramtayl merged commit 43ece86 into master Aug 6, 2019
@bramtayl
Copy link
Collaborator

bramtayl commented Aug 6, 2019

Ok sounds good

@davidanthoff davidanthoff deleted the api-tweak branch August 8, 2019 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants