Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http3: fix check for content length of the response #3998

Merged
merged 2 commits into from
Jul 29, 2023
Merged

http3: fix check for content length of the response #3998

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87fc2c9
fix: check response content-length other than request content-length
imroc Jul 27, 2023
4925daa
Update http3/client.go
marten-seemann Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions http3/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,8 +429,9 @@ func (c *client) doRequest(req *http.Request, conn quic.EarlyConnection, str qui
// Check that the server doesn't send more data in DATA frames than indicated by the Content-Length header (if set).
// See section 4.1.2 of RFC 9114.
var httpStr Stream
if _, ok := req.Header["Content-Length"]; ok && req.ContentLength >= 0 {
httpStr = newLengthLimitedStream(hstr, req.ContentLength)

marten-seemann marked this conversation as resolved.
Show resolved Hide resolved
if _, ok := res.Header["Content-Length"]; ok && res.ContentLength >= 0 {
httpStr = newLengthLimitedStream(hstr, res.ContentLength)
} else {
httpStr = hstr
}
Expand Down