-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update quic-go dependency #160
Conversation
0ff66f4
to
cddc36f
Compare
@marten-seemann let me know if you want me to adjust the PR in some way 🙂 |
I don't understand why I believe the problem is this step in the CI: https://github.com/ipdxco/unified-github-workflows/blob/61bc2a929b1a896da9559d6c4b14c574425da364/.github/workflows/go-check.yml#L36-L41
- name: Set up the Go version read from the go.mod file
uses: actions/setup-go@v5
with:
go-version-file: "release/go/go.mod" Not specifying a minor version for the go directive in the |
Still, I should thank you to for still putting effort into this 🙂 |
No it doesn't. See my PR, which was checked for |
If I was still maintaining this repo, I'd migrate away from these workflows. But since I'm currently not, everything will remain as is for now. |
I don't know what you changed in your PR, but this failed to merge after you removed the minor version because https://github.com/quic-go/webtransport-go/actions/runs/11396164669/job/31709549949#step:9:1 The same happens on my machine when I remove it and call |
The current version of webtransport is not compatible any more with the newest version of quic-go.
This PR updates the dependency and fixes uses of deprecated functions/types.