feat: print result symbol in addition to color #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the test abbreviation was printed in green, grey and red depending on the result. Colors are not available in all environments, e.g. when printing into a file. This commit adds symbols in addition to colors. +------+--------+ | | neqo | +------+--------+ | neqo | ✓(H,S) | | | ?() | | | ✕(R) | +------+--------+
|
Is it possible to detect color support? |
Probably not that hard. That said, say that you want to both print the results to screen and into a file:
Would one disable the symbols here in favor of colors? Fine for the results printed on screen. Not great for the one reading @marten-seemann does that make sense? |
|
You're right, this doesn't work well when piping output. |
marten-seemann
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the test abbreviation was printed in green, grey and red depending on the result. Colors are not available in all environments, e.g. when printing into a file.
This commit adds symbols in addition to colors.
Any format works for me. Using parenthesis first came to mind.