Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use defaults in meta.json #1310

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented Mar 14, 2022

This change allows to have unset fields in meta.json and fall back to their defaults
Currently it is required to explicitly put e.g. fieldnorms: false

This change allows to have unset fields in meta.json and fall back to their defaults
Currently it is required to explicitly put e.g. fieldnorms: false
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2022

Codecov Report

Merging #1310 (e1f4825) into main (2e255c4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head e1f4825 differs from pull request most recent head cfb5d4a. Consider uploading reports for the commit cfb5d4a to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1310   +/-   ##
=======================================
  Coverage   94.05%   94.06%           
=======================================
  Files         230      230           
  Lines       39350    39382   +32     
=======================================
+ Hits        37010    37043   +33     
+ Misses       2340     2339    -1     
Impacted Files Coverage Δ
src/schema/field_type.rs 83.33% <ø> (ø)
src/aggregation/mod.rs 97.96% <100.00%> (-0.02%) ⬇️
src/core/index_meta.rs 93.17% <100.00%> (+0.13%) ⬆️
src/indexer/merger.rs 98.96% <100.00%> (-0.01%) ⬇️
src/query/phrase_query/mod.rs 92.92% <100.00%> (-0.05%) ⬇️
src/schema/index_record_option.rs 100.00% <100.00%> (ø)
src/schema/text_options.rs 100.00% <100.00%> (ø)
src/fastfield/reader.rs 88.23% <0.00%> (-0.85%) ⬇️
src/store/index/mod.rs 98.37% <0.00%> (+0.54%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e255c4...cfb5d4a. Read the comment docs.

@fulmicoton fulmicoton merged commit b105bf7 into quickwit-oss:main Mar 14, 2022
This was referenced Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants