Removes all usage of block_on, and use a oneshot channel instead. #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
remove-block-on
branch
from
261f6cc
to
b9542cb
Compare
fulmicoton
commented
Mar 17, 2022
fulmicoton
force-pushed
the
remove-block-on
branch
2 times, most recently
from
8674eca
to
31166a1
Compare
fulmicoton
force-pushed
the
remove-block-on
branch
4 times, most recently
from
0d348e3
to
64557a4
Compare
Calling `block_on` panics in certain context. For instance, it panics when it is called in a the context of another call to block. Using it in tantivy is unnecessary. We replace it by a thin wrapper around a oneshot channel that supports both async/sync. Closes #898
fulmicoton
force-pushed
the
remove-block-on
branch
3 times, most recently
from
0f55152
to
10c6386
Compare
Codecov Report
@@ Coverage Diff @@
## main #1315 +/- ##
==========================================
+ Coverage 94.04% 94.26% +0.21%
==========================================
Files 230 232 +2
Lines 39384 40800 +1416
==========================================
+ Hits 37040 38461 +1421
+ Misses 2344 2339 -5
Continue to review full report at Codecov.
|
fulmicoton
force-pushed
the
remove-block-on
branch
from
10c6386
to
7f0ebdc
Compare
PSeitz
reviewed
Mar 18, 2022
6 tasks
fulmicoton
force-pushed
the
remove-block-on
branch
from
8187648
to
1edd9d9
Compare
PSeitz
reviewed
Mar 18, 2022
PSeitz
reviewed
Mar 18, 2022
fulmicoton
force-pushed
the
remove-block-on
branch
from
1edd9d9
to
a51f15d
Compare
Co-authored-by: PSeitz <PSeitz@users.noreply.github.com>
fulmicoton
force-pushed
the
remove-block-on
branch
from
b4fca1f
to
c7cb458
Compare
PSeitz
approved these changes
Mar 18, 2022
PSeitz
added a commit
that referenced
this pull request
May 3, 2022
) * Removes all usage of block_on, and use a oneshot channel instead. Calling `block_on` panics in certain context. For instance, it panics when it is called in a the context of another call to block. Using it in tantivy is unnecessary. We replace it by a thin wrapper around a oneshot channel that supports both async/sync. * Removing needless uses of async in the API. Co-authored-by: PSeitz <PSeitz@users.noreply.github.com>
This was referenced Jan 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
block_onpanics in certain context.For instance, it panics when it is called in a the context of another
call to block.
Using it in tantivy is unnecessary. We replace it by a thin wrapper
around a oneshot channel that supports both async/sync.