Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README following sections: features, benchmark illustration & FAQ. #1318

Merged
merged 13 commits into from
Mar 23, 2022
Merged

Update README following sections: features, benchmark illustration & FAQ. #1318

merged 13 commits into from
Mar 23, 2022

Conversation

maximkpa
Copy link
Contributor

No description provided.

@fmassot fmassot changed the title Updated features, benchmark illustration & FAQ. Update README following sections: features, benchmark illustration & FAQ. Mar 18, 2022
@fulmicoton
Copy link
Collaborator

Can we add Pisa to the bench graph?

@fmassot
Copy link
Contributor

fmassot commented Mar 19, 2022

Can we add Pisa to the bench graph?
Does the global performance is relevant enough to show it on the chart?

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2022 •
edited
Loading

Codecov Report

Merging #1318 (e43b118) into main (46d5de9) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1318      +/-   ##
==========================================
- Coverage   94.25%   94.22%   -0.04%     
==========================================
  Files         232      232              
  Lines       40801    40850      +49     
==========================================
+ Hits        38457    38489      +32     
- Misses       2344     2361      +17
Impacted Files Coverage Δ
src/error.rs 22.03% <0.00%> (-2.50%) ⬇️
src/lib.rs 97.61% <0.00%> (-1.21%) ⬇️
fastfield_codecs/src/multilinearinterpol.rs 98.01% <0.00%> (-1.00%) ⬇️
src/directory/watch_event_router.rs 95.79% <0.00%> (-0.85%) ⬇️
src/collector/histogram_collector.rs 98.99% <0.00%> (-0.51%) ⬇️
src/indexer/segment_writer.rs 96.30% <0.00%> (-0.02%) ⬇️
src/query/query_parser/query_parser.rs 95.35% <0.00%> (-0.01%) ⬇️
src/aggregation/bucket/histogram/histogram.rs 99.29% <0.00%> (-0.01%) ⬇️
src/fastfield/reader.rs 89.07% <0.00%> (ø)
src/fastfield/readers.rs 86.66% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46d5de9...e43b118. Read the comment docs.

fmassot
fmassot reviewed Mar 21, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
fmassot
fmassot reviewed Mar 21, 2022
View reviewed changes
README.md Show resolved Hide resolved
fmassot
fmassot reviewed Mar 21, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
fmassot
fmassot reviewed Mar 21, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
fmassot
fmassot requested changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@fmassot fmassot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments and remove the unused image.

fmassot
fmassot reviewed Mar 22, 2022
View reviewed changes
README.md Show resolved Hide resolved
fmassot
fmassot reviewed Mar 22, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
fmassot
fmassot reviewed Mar 22, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
fmassot
fmassot reviewed Mar 22, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
fmassot
fmassot reviewed Mar 22, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
fmassot
fmassot reviewed Mar 22, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
fmassot
fmassot approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@fmassot fmassot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me.

@fmassot
Copy link
Contributor

fmassot commented Mar 22, 2022

@fulmicoton can you take a final look?

fulmicoton
fulmicoton requested changes Mar 22, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
fulmicoton
fulmicoton reviewed Mar 23, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@fulmicoton fulmicoton merged commit 447811c into main Mar 23, 2022
@fulmicoton fulmicoton deleted the marketing branch March 23, 2022 01:02
PSeitz pushed a commit that referenced this pull request May 3, 2022
@maximkpa @PSeitz
Update README following sections: features, benchmark illustration & …
25a1711 
…FAQ. (#1318)

* Updated features, benchmark illustration & FAQ.
* Updated README: Feat,Graph,Non-Feat,Companies,FAQ
@PSeitz PSeitz mentioned this pull request May 16, 2022
Merged
This was referenced Jan 13, 2023
Closed
Closed
@PSeitz PSeitz mentioned this pull request Jan 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassot fmassot fmassot approved these changes

@fulmicoton fulmicoton fulmicoton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maximkpa @fulmicoton @fmassot @codecov-commenter