Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FruitHandle and MultiFruit public #1360

Merged
merged 2 commits into from
May 5, 2022
Merged

Conversation

ppodolsky
Copy link
Contributor

Hi! I've been coding dynamic Collector creation in my project and figured out that it was impossible to store FruitHandle inside struct or Vec because of (in)visibility of FruitHandle and MultiFruit. Is it ok to make them visible?

@codecov-commenter
Copy link

Codecov Report

Merging #1360 (fdea97e) into main (944302a) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1360   +/-   ##
=======================================
  Coverage   94.28%   94.29%           
=======================================
  Files         234      234           
  Lines       42528    42528           
=======================================
+ Hits        40099    40102    +3     
+ Misses       2429     2426    -3     
Impacted Files Coverage Δ
src/collector/mod.rs 48.21% <ø> (ø)
src/collector/multi_collector.rs 99.30% <ø> (ø)
src/fastfield/serializer/mod.rs 92.75% <0.00%> (+1.44%) ⬆️
src/directory/directory.rs 95.58% <0.00%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 944302a...fdea97e. Read the comment docs.

@fulmicoton fulmicoton merged commit 57a8d03 into quickwit-oss:main May 5, 2022
This was referenced Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants