Bugfix in the document deserialization. #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deserializing a json field does not expect the end of the document anymore. This behavior is well documented in serde_json. https://docs.serde.rs/serde_json/fn.from_reader.html Closes #1366
fulmicoton
added a commit
to quickwit-oss/quickwit
that referenced
this pull request
May 11, 2022
The target PR in tantivy is quickwit-oss/tantivy#1367 Closes #1411
fulmicoton
added a commit
to quickwit-oss/quickwit
that referenced
this pull request
May 11, 2022
The target PR in tantivy is quickwit-oss/tantivy#1367 Closes #1411
PSeitz
pushed a commit
that referenced
this pull request
May 12, 2022
Deserializing a json field does not expect the end of the document anymore. This behavior is well documented in serde_json. https://docs.serde.rs/serde_json/fn.from_reader.html Closes #1366
This was referenced Jan 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deserializing a json field does not expect the
end of the document anymore.
This behavior is well documented in serde_json.
https://docs.serde.rs/serde_json/fn.from_reader.html
Closes #1366