Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outdated variable naming and comments to alive bitset #1387

Conversation

k-yomo
Copy link
Contributor

@k-yomo k-yomo commented Jun 12, 2022

Some of the variables and comments for alive biset are still representing and describing old delete bitset.
This PR fixes those and also expired link.

@codecov-commenter
Copy link

Codecov Report

Merging #1387 (e61dd42) into main (328bd96) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1387      +/-   ##
==========================================
- Coverage   94.30%   94.29%   -0.01%     
==========================================
  Files         236      236              
  Lines       43088    43088              
==========================================
- Hits        40632    40630       -2     
- Misses       2456     2458       +2     
Impacted Files Coverage Δ
src/core/segment_component.rs 100.00% <ø> (ø)
src/core/segment_reader.rs 91.16% <100.00%> (ø)
src/indexer/index_writer.rs 96.74% <100.00%> (ø)
src/fastfield/serializer/mod.rs 91.30% <0.00%> (-1.45%) ⬇️
src/fastfield/reader.rs 89.07% <0.00%> (-0.85%) ⬇️
src/directory/watch_event_router.rs 95.79% <0.00%> (-0.85%) ⬇️
src/aggregation/agg_req_with_accessor.rs 94.48% <0.00%> (+0.78%) ⬆️
.../termdict/sstable_termdict/sstable/block_reader.rs 82.14% <0.00%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 328bd96...e61dd42. Read the comment docs.

@k-yomo k-yomo changed the title Fix outdated variables and comments to alive bitset Fix outdated variable naming and comments to alive bitset Jun 12, 2022
@fulmicoton
Copy link
Collaborator

Thank you @k-yomo

@fulmicoton fulmicoton merged commit 83d0c13 into quickwit-oss:main Jun 14, 2022
@k-yomo k-yomo deleted the fix-outdated-variables-and-comments-to-alive-bitset branch June 14, 2022 06:59
This was referenced Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants