Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated std package's constants on floats and integers #1420

Conversation

k-yomo
Copy link
Contributor

@k-yomo k-yomo commented Jul 21, 2022

We can use associated constants on floats and integers directly from rust 1.4.3, and imported constants are deprecated now.

This PR replaces those deprecated constants.

@codecov-commenter
Copy link

Codecov Report

Merging #1420 (d019506) into main (d24f31f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1420   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files         236      236           
  Lines       43775    43775           
=======================================
+ Hits        41243    41244    +1     
+ Misses       2532     2531    -1     
Impacted Files Coverage Δ
src/docset.rs 67.50% <ø> (ø)
src/indexer/index_writer.rs 96.82% <ø> (ø)
src/tokenizer/mod.rs 95.61% <ø> (ø)
common/src/lib.rs 89.33% <100.00%> (ø)
common/src/serialize.rs 89.80% <100.00%> (ø)
common/src/vint.rs 92.35% <100.00%> (ø)
query-grammar/src/query_grammar.rs 99.67% <100.00%> (ø)
src/fastfield/writer.rs 91.05% <100.00%> (ø)
src/fieldnorm/code.rs 100.00% <100.00%> (ø)
src/indexer/merger.rs 98.91% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d24f31f...d019506. Read the comment docs.

Copy link
Collaborator

@fulmicoton fulmicoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@fulmicoton fulmicoton merged commit af84e74 into quickwit-oss:main Jul 21, 2022
@k-yomo k-yomo deleted the replace-deprecated-std-floats-integers-constants branch July 21, 2022 23:23
This was referenced Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants