Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing nanosec truncation check on mac OS #1423

Merged

Conversation

k-yomo
Copy link
Contributor

@k-yomo k-yomo commented Jul 24, 2022

Fixes #1421

Nanosecond level precision is already truncated on some platforms including mac OS.
This PR fixes the failing test by comparing with microsecond, and I believe it's a little more valid test than asserting the inequality.

Related issue found on GitHub: edgedb/edgedb-go#209

@k-yomo k-yomo force-pushed the fix-test-datetime-nanosec-check branch from 303eb3d to b5a9843 Compare July 24, 2022 11:54
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2022

Codecov Report

Merging #1423 (b5a9843) into main (af84e74) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1423      +/-   ##
==========================================
- Coverage   94.22%   94.22%   -0.01%     
==========================================
  Files         236      236              
  Lines       43775    43775              
==========================================
- Hits        41248    41245       -3     
- Misses       2527     2530       +3     
Impacted Files Coverage Δ
src/lib.rs 96.48% <100.00%> (ø)
src/directory/directory.rs 90.14% <0.00%> (-1.41%) ⬇️
src/fastfield/reader.rs 89.07% <0.00%> (-0.85%) ⬇️
src/postings/stacker/expull.rs 98.57% <0.00%> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af84e74...b5a9843. Read the comment docs.

@lavrd
Copy link
Contributor

lavrd commented Jul 24, 2022

Thanks!

@fulmicoton fulmicoton merged commit 931bab8 into quickwit-oss:main Jul 25, 2022
@k-yomo k-yomo deleted the fix-test-datetime-nanosec-check branch July 25, 2022 11:27
This was referenced Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests::test_datetime fails
4 participants