Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for the special case of the root facet as prefix of other facets. #1448

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Check for the special case of the root facet as prefix of other facets. #1448

merged 1 commit into from
Aug 19, 2022

Conversation

adamreichold
Copy link
Collaborator

I noticed that the root facet is currently not considered a prefix of other facets in terms of Facet::is_prefix_of and made this PR to clarify that this is intentional or modify the implementation to include that case if not.

@fulmicoton
Copy link
Collaborator

@adamreichold. This was a bug indeed! Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants