Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactoring. Introducing a codec type enum. #1477

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Conversation

fulmicoton
Copy link
Collaborator

No description provided.

@fulmicoton fulmicoton requested a review from PSeitz August 24, 2022 17:04
Copy link
Contributor

@PSeitz PSeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there are some clippy errors

@codecov-commenter
Copy link

Codecov Report

Merging #1477 (9a0dd48) into main (513f682) will decrease coverage by 0.00%.
The diff coverage is 79.80%.

@@            Coverage Diff             @@
##             main    #1477      +/-   ##
==========================================
- Coverage   94.08%   94.08%   -0.01%     
==========================================
  Files         239      239              
  Lines       44768    44789      +21     
==========================================
+ Hits        42120    42138      +18     
- Misses       2648     2651       +3     
Impacted Files Coverage Δ
fastfield_codecs/src/bitpacked.rs 100.00% <ø> (ø)
fastfield_codecs/src/linear.rs 99.57% <ø> (ø)
fastfield_codecs/src/main.rs 1.01% <0.00%> (ø)
src/fastfield/mod.rs 94.76% <ø> (-0.01%) ⬇️
src/fastfield/reader.rs 88.05% <42.85%> (+0.32%) ⬆️
src/fastfield/serializer/mod.rs 89.21% <79.16%> (-1.08%) ⬇️
fastfield_codecs/src/lib.rs 97.14% <95.34%> (+0.54%) ⬆️
fastfield_codecs/src/blockwise_linear.rs 100.00% <100.00%> (ø)
src/fastfield/gcd.rs 100.00% <100.00%> (ø)
src/fastfield/multivalued/mod.rs 94.11% <0.00%> (-2.95%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fulmicoton fulmicoton merged commit 8bbb22e into main Aug 24, 2022
@fulmicoton fulmicoton deleted the minor-refact branch August 24, 2022 17:21
This was referenced Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants