Hiding useless symbols and removing code. #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
hiding-useless-symbols
branch
from
8fb8fe9
to
2ad02c2
Compare
Codecov Report
@@ Coverage Diff @@
## main #1522 +/- ##
=======================================
Coverage 94.07% 94.08%
=======================================
Files 244 244
Lines 45118 45088 -30
=======================================
- Hits 42445 42421 -24
+ Misses 2673 2667 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
PSeitz
reviewed
Sep 16, 2022
| @@ -132,14 +133,6 @@ pub const ALL_CODEC_TYPES: [FastFieldCodecType; 3] = [ | |||
| FastFieldCodecType::Linear, | |||
| ]; | |||
|
|
|||
| #[derive(Debug, Clone)] | |||
| /// Statistics are used in codec detection and stored in the fast field footer. | |||
| pub struct FastFieldStats { | |||
There was a problem hiding this comment.
I was thinking about going the other way and replace all the methods with returning the stats
There was a problem hiding this comment.
You can do a follow up PR if you see an opportunity to simplify the code.
PSeitz
approved these changes
Sep 16, 2022
This was referenced Jan 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.