Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for deleting all documents matching query #1535

Merged
merged 5 commits into from
Sep 22, 2022
Merged

Conversation

trinity-1686a
Copy link
Contributor

@trinity-1686a trinity-1686a commented Sep 19, 2022

fix half of #1494

@fulmicoton
Copy link
Collaborator

It only partially fixes #1494

We also need to add a query that matches a dicitonary. Can you create a separate issue maybe?

@codecov-commenter
Copy link

Codecov Report

Merging #1535 (c94c9c3) into main (ed68afb) will increase coverage by 0.11%.
The diff coverage is 93.87%.

@@            Coverage Diff             @@
##             main    #1535      +/-   ##
==========================================
+ Coverage   93.82%   93.93%   +0.11%     
==========================================
  Files         247      249       +2     
  Lines       45947    45976      +29     
==========================================
+ Hits        43109    43187      +78     
+ Misses       2838     2789      -49     
Impacted Files Coverage Δ
src/indexer/operation.rs 0.00% <ø> (ø)
src/indexer/delete_queue.rs 94.76% <33.33%> (-3.46%) ⬇️
src/indexer/index_writer.rs 97.17% <100.00%> (+0.17%) ⬆️
src/fastfield/multivalued/mod.rs 96.37% <0.00%> (-1.56%) ⬇️
src/store/index/mod.rs 97.83% <0.00%> (-0.55%) ⬇️
src/termdict/sstable_termdict/sstable/merge/mod.rs 92.52% <0.00%> (-0.07%) ⬇️
src/indexer/merger.rs 98.83% <0.00%> (-0.07%) ⬇️
src/schema/mod.rs 100.00% <0.00%> (ø)
src/indexer/mod.rs 100.00% <0.00%> (ø)
src/query/query.rs 85.71% <0.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fulmicoton fulmicoton merged commit fa3d786 into main Sep 22, 2022
@fulmicoton fulmicoton deleted the query-delete branch September 22, 2022 12:26
This was referenced Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants