Avoid slicing a string in DocParsingError. #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not convinced that this is better since there are still allocations, etc ... but the code is shorter and it is only an error path thing. |
Codecov Report
@@ Coverage Diff @@
## main #1559 +/- ##
=======================================
Coverage 93.82% 93.83%
=======================================
Files 250 250
Lines 46117 46117
=======================================
+ Hits 43269 43272 +3
+ Misses 2848 2845 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fulmicoton
reviewed
Sep 26, 2022
| format!("{:?}...", &invalid_json[0..20]) | ||
| }; | ||
| DocParsingError::InvalidJson(sample_json) | ||
| let sample = invalid_json.chars().take(20).collect(); |
There was a problem hiding this comment.
the best would be std::floor_char_boundary but it is not available in stable.
fulmicoton
approved these changes
Sep 26, 2022
|
nice :) |
This was referenced Jan 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1339.