Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic on duplicate field names fixes #1601 #1647

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented Oct 26, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Merging #1647 (5ca01c2) into main (c24157f) will increase coverage by 0.05%.
The diff coverage is 94.01%.

@@            Coverage Diff             @@
##             main    #1647      +/-   ##
==========================================
+ Coverage   93.97%   94.03%   +0.05%     
==========================================
  Files         253      254       +1     
  Lines       47716    48158     +442     
==========================================
+ Hits        44843    45283     +440     
- Misses       2873     2875       +2     
Impacted Files Coverage Δ
fastfield_codecs/src/main.rs 0.52% <0.00%> (-0.01%) ⬇️
src/fastfield/writer.rs 88.52% <0.00%> (ø)
src/indexer/sorted_doc_id_multivalue_column.rs 95.00% <0.00%> (ø)
src/query/bitset/mod.rs 99.45% <ø> (ø)
src/query/mod.rs 100.00% <ø> (ø)
src/fastfield/multivalued/writer.rs 98.86% <50.00%> (ø)
src/schema/field_type.rs 77.52% <50.00%> (+1.10%) ⬆️
src/fastfield/multivalued/reader.rs 83.17% <60.00%> (-2.40%) ⬇️
src/indexer/sorted_doc_id_column.rs 95.00% <66.66%> (ø)
src/schema/schema.rs 98.64% <66.66%> (-0.15%) ⬇️
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fulmicoton fulmicoton merged commit 0c2bd36 into main Oct 26, 2022
@fulmicoton fulmicoton deleted the duplicate_field_names branch October 26, 2022 07:17
This was referenced Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants