add docstore version #1652
Merged
add docstore version #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #1589
Codecov Report
@@ Coverage Diff @@
## main #1652 +/- ##
==========================================
+ Coverage 93.97% 94.02% +0.04%
==========================================
Files 253 254 +1
Lines 47716 48160 +444
==========================================
+ Hits 44843 45284 +441
- Misses 2873 2876 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fulmicoton
reviewed
Nov 1, 2022
src/store/footer.rs
Outdated
| BinarySerializable::serialize(&self.offset, writer)?; | ||
| BinarySerializable::serialize(&self.decompressor.get_id(), writer)?; | ||
| writer.write_all(&[0; 15])?; | ||
| Ok(()) | ||
| } | ||
|
|
||
| fn deserialize<R: io::Read>(reader: &mut R) -> io::Result<Self> { | ||
| let _doc_store_version = u32::deserialize(reader)?; |
There was a problem hiding this comment.
Can we have a check on the version?
(so that we have an error if we try to open a different version)
fulmicoton
approved these changes
Nov 4, 2022
This was referenced Jan 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1589