Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a expand_dots JsonObjectOptions. #1687

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Conversation

fulmicoton
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2022

Codecov Report

Merging #1687 (bf1ec91) into main (e758080) will increase coverage by 0.00%.
The diff coverage is 96.89%.

❗ Current head bf1ec91 differs from pull request most recent head 639fef9. Consider uploading reports for the commit 639fef9 to get more accurate results

@@           Coverage Diff           @@
##             main    #1687   +/-   ##
=======================================
  Coverage   94.04%   94.05%           
=======================================
  Files         256      256           
  Lines       49169    49249   +80     
=======================================
+ Hits        46243    46321   +78     
- Misses       2926     2928    +2     
Impacted Files Coverage Δ
src/query/query_parser/query_parser.rs 95.05% <85.71%> (+<0.01%) ⬆️
src/indexer/json_term_writer.rs 99.79% <100.00%> (+0.01%) ⬆️
src/indexer/mod.rs 100.00% <100.00%> (ø)
src/indexer/segment_writer.rs 97.69% <100.00%> (+<0.01%) ⬆️
src/schema/json_object_options.rs 87.87% <100.00%> (+2.16%) ⬆️
src/schema/term.rs 88.76% <100.00%> (+0.20%) ⬆️
src/fastfield/multivalued/mod.rs 98.45% <0.00%> (-0.78%) ⬇️
src/postings/stacker/expull.rs 98.57% <0.00%> (-0.48%) ⬇️
src/store/index/mod.rs 98.37% <0.00%> (+0.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@trinity-1686a trinity-1686a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.
Also I think having a const EXPAND_DOT or something along the line would be a nice to have

src/schema/json_object_options.rs Outdated Show resolved Hide resolved
src/schema/json_object_options.rs Show resolved Hide resolved
Related with quickwit#2345.
@fulmicoton fulmicoton merged commit 0b40a7f into main Nov 21, 2022
@fulmicoton fulmicoton deleted the issue/quickwit-2345 branch November 21, 2022 14:03
This was referenced Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants